High jump in pvp

[Taishiji]

the skill works but you dont go anywhere
please fix this

[Koma]

This is a "working as intended" and "by design" issue as far eAthena goes. Read further though as this may be corrected anyways during tomorrow's maintenance.

This is due to the following code in eAthena's skill.c in relation to the latter quoted code regarding PvP arena mapflags (noteleport.txt) -- click filenames for the exact source code information from eAthena.

Also see these for reference:
http://svn.eathena.ws/bugs/changeset/14106 (10/27/09)
http://svn.eathena.ws/bugs/changeset/10355 (4/25/07)

In short, High Jump is designed (by Skotlex of eAthena) to fail on noteleport maps except for WoESE (however it was disabled in the skill_nocast_db) and Battlegrounds. This means it fails in PvP (also according to Inkfish).

However, this is the reverse of what even RMS says @ http://ratemyserver.net/index.php?page= ... rch=Search -- possibly due to RMS using skill descriptions from translation sources and code/database info from eAthena which are conflicting with each other. We can revise this on Amistr, but we need more details first.

case TK_HIGHJUMP:
{
int x,y, dir = unit_getdir(src);

//Fails on noteleport maps, except for GvG and BG maps [Skotlex]
if( map[src->m].flag.noteleport &&
!(map[src->m].flag.battleground || map_flag_gvg2(src->m) )
) {
x = src->x;
y = src->y;
} else {
x = src->x + dirx[dir]*skilllv*2;
y = src->y + diry[dir]*skilllv*2;
}

clif_skill_nodamage(src,bl,TK_HIGHJUMP,skilllv,1);
if(!map_count_oncell(src->m,x,y,BL_PC|BL_NPC|BL_MOB) && map_getcell(src->m,x,y,CELL_CHKREACH)) {
clif_slide(src,x,y);
unit_movepos(src, x, y, 1, 0);
}
}
break;

// PvP Arenas=======================
pvp_y_room mapflag noteleport
pvp_y_1-1 mapflag noteleport
pvp_y_1-2 mapflag noteleport
pvp_y_1-3 mapflag noteleport
...

However, if the original bug report is true, it's a very easy fix:

//Fails on noteleport maps, except for PvP and WoE:FE maps [Koma]
if( map[src->m].flag.noteleport &&
!(map_flag_vs(src->m) || map_flag_gvg(src->m) )
) {

This just makes it so there are no exceptions for BGs and WoESE, and allows it to be used in PvP and WoEFE (which it seems it didn't work in either. We have two sources from iRO and EuRO claiming it should not work in WoESE and should work in WoEFE.

Additional Note: There is a bug though regarding KvM not permitting it. This is due to the way KvM is scripted to not use battlegrounds mapflags when it really should. Another question raised is regarding Ninja's Shadow Jump which is currently disabled in GvG and Battlegrounds. Should it be disabled in Battlegrounds also?